Green’s Dictionary of Slang

knick-knack n.

[SE knick-knack, a pleasing or curious trifle]

1. the penis.

[UK]Behn Lucky Chance V iv: Some rich Commodities, I am sure, and some fine Knick-knack will fall to thy share.
[UK]Farmer Vocabula Amatoria (1966) 96: Don, m. The penis; ‘the knick-knack’.

2. the vagina.

[UK]Farmer & Henley Sl. and Its Analogues.
[UK]Farmer Vocabula Amatoria (1966) 134: Forêt de bois-mort, f. The female pudendum; ‘the knick-knack’.

3. (gay) a small penis.

[US]B. Rodgers Queens’ Vernacular 185: small penis [...] knickknack.

4. see nick-nack n. (5)